refactor: item 29 cleanup

C14 C16 C17 C18 C20 A11 A15 X10 X12 X15: dead Steam count code, GameNames, steamIdText, one query per game for the finished estimate, no API versioning config, open-in-view off, CORS from APP_FRONTEND_URL, non-root image, prune only up to the highest known id.

src/test/java/core_service/modules/account/repo/AccountCleanupRepositoryTest.java

@@ -111,10 +111,16 @@ class AccountCleanupRepositoryTest extends AbstractPersistenceTest {
     void findOrphans_ReturnsUsersNotInTheList() {
         repository.addDeleted(List.of(7L));
 
-        assertThat(repository.findOrphans(List.of(2L))).containsExactly(1L, 7L);
+        assertThat(repository.findOrphans(List.of(2L, 8L))).containsExactly(1L, 7L);
         assertThat(repository.findOrphans(List.of(1L, 2L, 7L))).isEmpty();
     }
 
+    // Auth reads its ids before the call: a user who registers in between has a higher id and is no orphan.
+    @Test
+    void findOrphans_SkipsUsersAboveTheHighestKnownId() {
+        assertThat(repository.findOrphans(List.of(1L))).isEmpty();
+    }
+
     // A new table with user rows must be in the purge list, or "Delete my account" leaves its rows behind.
     @Test
     void tables_CoverEveryTableWithAUserId() {

src/test/java/core_service/modules/library/domain/GameNamesTest.java

@@ -0,0 +1,15 @@
+package core_service.modules.library.domain;
+
+import core_service.shared.test.AbstractUnitTest;
+import org.junit.jupiter.api.Test;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+class GameNamesTest extends AbstractUnitTest {
+
+    @Test
+    void normalize_DropsCaseAccentsTrademarksAndPunctuation() {
+        assertThat(GameNames.normalize("  Pokémon™: Let's Go, Pikachu!® ")).isEqualTo("pokemon let s go pikachu");
+        assertThat(GameNames.normalize("The Witcher 3: Wild Hunt")).isEqualTo(GameNames.normalize("The Witcher® 3 - Wild Hunt"));
+    }
+}

src/test/java/core_service/modules/library/service/SpeedrunMatchTest.java

@@ -18,12 +18,6 @@ class SpeedrunMatchTest extends AbstractUnitTest {
     private static final SpeedrunApiService.Game PREY_2006 = hit("prey", "Prey", 2006);
     private static final SpeedrunApiService.Game PREY_2017 = hit("prey2017", "Prey (2017)", 2017);
 
-    @Test
-    void normalize_DropsCaseAccentsTrademarksAndPunctuation() {
-        assertThat(SpeedrunMatch.normalize("  Pokémon™: Let's Go, Pikachu!® ")).isEqualTo("pokemon let s go pikachu");
-        assertThat(SpeedrunMatch.normalize("The Witcher 3: Wild Hunt")).isEqualTo(SpeedrunMatch.normalize("The Witcher® 3 - Wild Hunt"));
-    }
-
     @Test
     void candidates_YearSuffixTellsTheRemakeApart() {
         assertThat(SpeedrunMatch.candidates("Prey", Set.of(2017), List.of(PREY_2006, PREY_2017))).containsExactly(PREY_2017);

src/test/java/core_service/modules/steam_adapter/service/SteamApiServiceCacheTest.java

@@ -108,7 +108,7 @@ class SteamApiServiceCacheTest extends AbstractIntegrationTest {
 
     @Test
     void getOwnedGames_TransientSteamError_IsTriedAgain() {
-        SteamOwnedGamesResponse games = new SteamOwnedGamesResponse(new SteamOwnedGamesResponse.OwnedGamesResponse(1,
+        SteamOwnedGamesResponse games = new SteamOwnedGamesResponse(new SteamOwnedGamesResponse.OwnedGamesResponse(
                 List.of(new SteamOwnedGamesResponse.Game(220, "Half-Life 2", 60, null, true, 0))));
         when(steamRestClient.get().uri(any(Function.class)).retrieve().body(SteamOwnedGamesResponse.class))
                 .thenAnswer(invocation -> {

src/test/java/core_service/modules/steam_adapter/service/SteamApiServiceTest.java

@@ -45,27 +45,6 @@ class SteamApiServiceTest {
         ReflectionTestUtils.setField(steamApiService, "apiKey", "test-api-key");
     }
 
-    @Test
-    void getOwnedGamesCount_shouldReturnCount() {
-        String steamId = "76561197960435530";
-        String jsonResponse = """
-                {
-                    "response": {
-                        "game_count": 42
-                    }
-                }
-                """;
-
-        server.expect(requestTo(containsString("/IPlayerService/GetOwnedGames/v1/")))
-                .andExpect(queryParam("steamid", steamId))
-                .andExpect(queryParam("key", "test-api-key"))
-                .andRespond(withSuccess(jsonResponse, MediaType.APPLICATION_JSON));
-
-        int result = steamApiService.getOwnedGamesCount(steamId);
-
-        assertThat(result).isEqualTo(42);
-    }
-
     @Test
     void getPlayerSummary_shouldReturnPlayer() {
         String steamId = "76561197960435530";
@@ -135,15 +114,6 @@ class SteamApiServiceTest {
         assertThat(steamApiService.getOwnedGames("76561197960435530")).hasSize(1);
     }
 
-    @Test
-    void getOwnedGamesCount_shouldCountUnvettedApps() {
-        server.expect(requestTo(containsString("/IPlayerService/GetOwnedGames/v1/")))
-                .andExpect(queryParam("skip_unvetted_apps", "0"))
-                .andRespond(withSuccess("{\"response\":{\"game_count\":1}}", MediaType.APPLICATION_JSON));
-
-        assertThat(steamApiService.getOwnedGamesCount("76561197960435530")).isEqualTo(1);
-    }
-
     @Test
     void getOwnedGames_shouldReturnGamesEvenWithNullValues() {
         String steamId = "76561197960435530";

src/test/java/core_service/shared/test/AbstractWebMvcTest.java

@@ -1,13 +0,0 @@
-package core_service.shared.test;
-
-import org.junit.jupiter.api.Tag;
-import org.springframework.boot.webmvc.test.autoconfigure.WebMvcTest;
-
-/**
- * Base class for WebMvc tests.
- * Slices the web layer.
- */
-@Tag("WebMvcTest")
-@WebMvcTest
-public abstract class AbstractWebMvcTest {
-}