feat(achievements): dashboard card, library badge, 100 % hint and profile stats

2026-09-25 10:13:31 +02:00
1 parent 2efdf64675
commit 085fcf15a4
@@ -0,0 +1,87 @@
+import {Link} from 'react-router-dom';
+import {useTranslation} from 'react-i18next';
+import {Trophy} from 'lucide-react';
+
+import {Card} from '@/components/ui/card';
+import GameCover from './GameCover.jsx';
+
+/**
+ * @param summary the answer of GET /api/library/achievements/summary
+ */
+export default function AchievementsCard({summary}) {
+    const {t, i18n} = useTranslation();
+    const closest = summary.closest ?? [];
+    const started = summary.startedGames ?? 0;
+    const pending = summary.pendingGames ?? 0;
+    const hidden = summary.hiddenGames ?? 0;
+    // A private profile keeps games pending; the privacy hint explains that better than the pending count.
+    const steamHidesAll = hidden > 0 && started === 0;
+
+    const stats = [
+        [(summary.unlocked ?? 0).toLocaleString(i18n.language), t('DASHBOARD.ACHIEVEMENTS.UNLOCKED')],
+        [(summary.perfectGames ?? 0).toLocaleString(i18n.language), t('DASHBOARD.ACHIEVEMENTS.PERFECT')],
+        [summary.averageCompletion != null ? `${summary.averageCompletion.toLocaleString(i18n.language)} %` : '–',
+            t('DASHBOARD.ACHIEVEMENTS.AVERAGE')],
+    ];
+
+    return (
+        <Card className="gap-5 p-5">
+            <h2 className="flex items-center gap-2 font-semibold">
+                <Trophy className="size-4 text-amber-500"/>
+                {t('DASHBOARD.ACHIEVEMENTS.TITLE')}
+            </h2>
+
+            <div className="grid grid-cols-3 gap-3">
+                {stats.map(([value, label]) => (
+                    <div key={label} className="rounded-lg bg-muted/50 p-3 text-center">
+                        <div className="text-xl md:text-2xl font-bold tabular-nums">{value}</div>
+                        <div className="text-xs text-muted-foreground">{label}</div>
+                    </div>
+                ))}
+            </div>
+
+            {started === 0 && pending === 0 && hidden === 0 && (
+                <p className="text-sm text-muted-foreground">{t('DASHBOARD.ACHIEVEMENTS.NONE')}</p>
+            )}
+
+            {closest.length > 0 && (
+                <div className="space-y-2">
+                    <h3 className="text-sm font-medium">{t('DASHBOARD.ACHIEVEMENTS.CLOSEST')}</h3>
+                    <ul className="space-y-2">
+                        {closest.map((game) => (
+                            <li key={game.appid}>
+                                <Link
+                                    to={`/library/${game.appid}`}
+                                    className="group flex items-center gap-3 rounded-lg p-1 transition-colors hover:bg-muted/50"
+                                >
+                                    <GameCover appid={game.appid} className="w-16 shrink-0"/>
+                                    <div className="min-w-0 flex-1 space-y-1">
+                                        <div className="flex items-baseline justify-between gap-2">
+                                            <span className="truncate text-sm font-medium group-hover:text-primary transition-colors">
+                                                {game.name ?? `App ${game.appid}`}
+                                            </span>
+                                            <span className="shrink-0 text-xs text-muted-foreground tabular-nums">
+                                                {game.unlocked} / {game.total}
+                                            </span>
+                                        </div>
+                                        <div className="h-1.5 overflow-hidden rounded-full bg-muted">
+                                            <div className="h-full rounded-full bg-amber-500"
+                                                 style={{width: `${(game.unlocked / game.total) * 100}%`}}/>
+                                        </div>
+                                    </div>
+                                </Link>
+                            </li>
+                        ))}
+                    </ul>
+                </div>
+            )}
+
+            {pending > 0 && !steamHidesAll && (
+                <p className="text-xs text-muted-foreground">{t('DASHBOARD.ACHIEVEMENTS.PENDING', {count: pending})}</p>
+            )}
+            {steamHidesAll && (
+                <p className="text-xs text-muted-foreground">{t('DASHBOARD.ACHIEVEMENTS.HIDDEN')}</p>
+            )}
+        </Card>
+    );
+}
@@ -0,0 +1,52 @@
+// @vitest-environment jsdom
+import {afterEach, describe, expect, it, vi} from 'vitest';
+import {cleanup, render, screen} from '@testing-library/react';
+import {MemoryRouter} from 'react-router-dom';
+import AchievementsCard from './AchievementsCard.jsx';
+
+vi.mock('react-i18next', () => import('../test/i18n-mock.js'));
+
+const summary = (extra = {}) => ({
+    unlocked: 24, startedGames: 4, perfectGames: 2, averageCompletion: 71.3, pendingGames: 0, hiddenGames: 0,
+    closest: [{appid: 20, name: 'Portal 2', unlocked: 3, total: 4}], ...extra,
+});
+
+const renderCard = (data) => render(<MemoryRouter><AchievementsCard summary={data}/></MemoryRouter>);
+
+describe('AchievementsCard', () => {
+    afterEach(() => {
+        cleanup();
+    });
+
+    it('shows the totals and links the games closest to 100 %', () => {
+        renderCard(summary());
+
+        expect(screen.getByText('24')).toBeTruthy();
+        expect(screen.getByText('2')).toBeTruthy();
+        expect(screen.getByText('71,3 %')).toBeTruthy();
+        expect(screen.getByRole('link', {name: /Portal 2/}).getAttribute('href')).toBe('/library/20');
+        expect(screen.getByText('3 / 4')).toBeTruthy();
+        expect(screen.queryByText(/DASHBOARD.ACHIEVEMENTS.PENDING/)).toBeNull();
+    });
+
+    it('says how many games are still syncing', () => {
+        renderCard(summary({pendingGames: 7}));
+
+        expect(screen.getByText('DASHBOARD.ACHIEVEMENTS.PENDING:7')).toBeTruthy();
+    });
+
+    it('explains hidden achievements when nothing is visible', () => {
+        renderCard(summary({unlocked: 0, startedGames: 0, perfectGames: 0, averageCompletion: null, hiddenGames: 5,
+            pendingGames: 200, closest: []}));
+
+        expect(screen.getByText('DASHBOARD.ACHIEVEMENTS.HIDDEN')).toBeTruthy();
+        expect(screen.queryByText(/DASHBOARD.ACHIEVEMENTS.PENDING/)).toBeNull();
+        expect(screen.getByText('–')).toBeTruthy();
+    });
+
+    it('says so when nothing is unlocked yet', () => {
+        renderCard(summary({unlocked: 0, startedGames: 0, perfectGames: 0, averageCompletion: null, closest: []}));
+
+        expect(screen.getByText('DASHBOARD.ACHIEVEMENTS.NONE')).toBeTruthy();
+    });
+});
@@ -0,0 +1,59 @@
+import {useState} from 'react';
+import {useTranslation} from 'react-i18next';
+import {toast} from 'sonner';
+import {Loader2, Trophy} from 'lucide-react';
+
+import {Button} from '@/components/ui/button';
+import {Card} from '@/components/ui/card';
+import useSessionExpired from '../hooks/useSessionExpired.js';
+import {saveGameStatus} from '../utils/backlog.js';
+
+/**
+ * Shown for a game with every achievement unlocked that is not marked as 100 % yet.
+ *
+ * @param onChanged gets the saved backlog entry
+ */
+export default function CompletedHint({game, onChanged}) {
+    const {t} = useTranslation();
+    const expireSession = useSessionExpired();
+    const [busy, setBusy] = useState(false);
+
+    const allUnlocked = game.hasAchievements && game.statsVisible && game.achievementsTotal > 0
+        && game.achievementsUnlocked >= game.achievementsTotal;
+    if (!allUnlocked || game.status === 'COMPLETED') return null;
+
+    const setCompleted = async () => {
+        setBusy(true);
+        try {
+            const response = await saveGameStatus(game.appid, 'COMPLETED');
+            if (response.status === 401) {
+                expireSession();
+                return;
+            }
+            if (!response.ok) {
+                toast.error(t('BACKLOG.SAVE_FAILED'));
+                return;
+            }
+            onChanged(await response.json());
+            toast.success(t('BACKLOG.SAVED'));
+        } catch (err) {
+            console.error('set completed error:', err);
+            toast.error(t('INFO.ERROR.NETWORK_FAILURE'));
+        } finally {
+            setBusy(false);
+        }
+    };
+
+    return (
+        <Card className="gap-3 border-amber-500/40 bg-amber-500/5 p-4 sm:flex-row sm:items-center sm:gap-4">
+            <div className="flex flex-1 items-start gap-3 sm:items-center">
+                <Trophy className="size-5 shrink-0 text-amber-500"/>
+                <p className="text-sm">{t('GAME_DETAIL.ALL_UNLOCKED')}</p>
+            </div>
+            <Button size="sm" className="self-end sm:self-auto" onClick={setCompleted} disabled={busy}>
+                {busy && <Loader2 className="animate-spin"/>}
+                {t('GAME_DETAIL.SET_COMPLETED')}
+            </Button>
+        </Card>
+    );
+}
@@ -0,0 +1,48 @@
+// @vitest-environment jsdom
+import {afterEach, beforeEach, describe, expect, it, vi} from 'vitest';
+import {cleanup, fireEvent, render, screen, waitFor} from '@testing-library/react';
+import {MemoryRouter} from 'react-router-dom';
+import CompletedHint from './CompletedHint.jsx';
+
+vi.mock('react-i18next', () => import('../test/i18n-mock.js'));
+vi.mock('sonner', () => ({toast: {success: vi.fn(), error: vi.fn()}}));
+
+const game = {appid: 220, status: 'FINISHED', hasAchievements: true, statsVisible: true, achievementsTotal: 10, achievementsUnlocked: 10};
+const renderHint = (props) => render(<MemoryRouter><CompletedHint game={game} onChanged={() => {}} {...props}/></MemoryRouter>);
+
+describe('CompletedHint', () => {
+    beforeEach(() => {
+        localStorage.setItem('tbp_jwt', 'token');
+        globalThis.fetch = vi.fn(async (url, init) => ({
+            ok: true, status: 200, json: async () => ({...JSON.parse(init.body), rating: 5, notes: 'keep', priority: null}),
+        }));
+    });
+
+    afterEach(() => {
+        cleanup();
+        localStorage.clear();
+    });
+
+    it.each([
+        ['a game already at 100 %', {...game, status: 'COMPLETED'}],
+        ['a game with achievements left', {...game, achievementsUnlocked: 9}],
+        ['a game without achievements', {...game, hasAchievements: false, achievementsTotal: 0, achievementsUnlocked: 0}],
+        ['a game whose achievements Steam hides', {...game, statsVisible: false}],
+    ])('is hidden for %s', (_, other) => {
+        renderHint({game: other});
+
+        expect(screen.queryByRole('button')).toBeNull();
+    });
+
+    it('sets only the status to COMPLETED', async () => {
+        const onChanged = vi.fn();
+        renderHint({onChanged});
+
+        fireEvent.click(screen.getByRole('button', {name: 'GAME_DETAIL.SET_COMPLETED'}));
+
+        await waitFor(() => expect(onChanged).toHaveBeenCalledWith({status: 'COMPLETED', rating: 5, notes: 'keep', priority: null}));
+        const [url, init] = fetch.mock.calls[0];
+        expect(url).toMatch(/\/api\/library\/games\/220\/status$/);
+        expect(JSON.parse(init.body)).toEqual({status: 'COMPLETED'});
+    });
+});