test: data router, one render helper, fetchRoutes in every test

src/pages/AdminHintsPage.test.jsx

@@ -5,6 +5,7 @@ import {MemoryRouter} from 'react-router-dom';
 import {toast} from 'sonner';
 import AdminHintsPage from './AdminHintsPage.jsx';
 import {PreferencesProvider} from '../context/PreferencesContext.jsx';
+import {fetchRoutes, json} from '../test/fetchRoutes.js';
 
 vi.mock('react-i18next', () => import('../test/i18n-mock.js'));
 vi.mock('sonner', () => ({toast: {success: vi.fn(), error: vi.fn()}}));
@@ -15,7 +16,12 @@ const ACTIVE = {id: 2, textEn: 'Server update tonight', textDe: null, kind: 'DIS
     createdBy: 1, createdAt: at(-1), doneCount: 3};
 const ENDED = {...ACTIVE, id: 1, textEn: 'Old news', startsAt: at(-3), endsAt: at(-2), status: 'ENDED', doneCount: 0};
 
-const answer = (status, body) => ({ok: status < 300, status, headers: new Headers(), json: async () => body});
+const withRoutes = (routes) => fetchRoutes({
+    'GET /api/admin/hints': json(200, {results: [ACTIVE, ENDED]}),
+    'POST /api/admin/hints': json(201, {id: 3}),
+    'PUT /api/admin/hints/2/end': json(204),
+    ...routes,
+});
 const calls = (method) => fetch.mock.calls.filter(([, init]) => (init?.method ?? 'GET') === method);
 
 const renderPage = () => render(<MemoryRouter><PreferencesProvider><AdminHintsPage/></PreferencesProvider></MemoryRouter>);
@@ -23,11 +29,7 @@ const renderPage = () => render(<MemoryRouter><PreferencesProvider><AdminHintsPa
 describe('AdminHintsPage', () => {
     beforeEach(() => {
         localStorage.setItem('tbp_session', '1');
-        globalThis.fetch = vi.fn(async (url, init) => {
-            if (init?.method === 'POST') return answer(201, {id: 3});
-            if (init?.method === 'PUT') return answer(204);
-            return answer(200, {results: [ACTIVE, ENDED]});
-        });
+        withRoutes({});
     });
 
     afterEach(() => {
@@ -68,8 +70,7 @@ describe('AdminHintsPage', () => {
     });
 
     it('explains an invalid time range', async () => {
-        fetch.mockImplementation(async (url, init) =>
-            (init?.method === 'POST' ? answer(400, {code: 'INVALID_HINT'}) : answer(200, {results: []})));
+        withRoutes({'GET /api/admin/hints': json(200, {results: []}), 'POST /api/admin/hints': json(400, {code: 'INVALID_HINT'})});
         renderPage();
         await screen.findByText('ADMIN_HINTS.EMPTY');
 
@@ -82,7 +83,7 @@ describe('AdminHintsPage', () => {
     it('takes the status from the server, not from the browser clock', async () => {
         // The server ended the hint by its own clock; by the browser clock the end is still 5 s away.
         const endedOnServer = {...ACTIVE, endsAt: new Date(Date.now() + 5_000).toISOString(), status: 'ENDED'};
-        fetch.mockImplementation(async () => answer(200, {results: [endedOnServer]}));
+        withRoutes({'GET /api/admin/hints': json(200, {results: [endedOnServer]})});
         renderPage();
 
         await screen.findByText('Server update tonight');
@@ -103,7 +104,7 @@ describe('AdminHintsPage', () => {
     });
 
     it('shows "no access" to a non-admin', async () => {
-        fetch.mockImplementation(async () => answer(403));
+        withRoutes({'GET /api/admin/hints': json(403, {})});
         renderPage();
 
         expect(await screen.findByText('ADMIN_HINTS.NO_ACCESS')).toBeTruthy();