fix(about): show original company logos again
Remove the logo invert added in 07a9b8b and its test.
The inverted logos were not wanted, so the originals show again.
This commit is contained in:
1 parent
07a9b8bc11
commit
106d39453d
3 files changed
+5
-23
No files matched your search
@@ -73,8 +73,7 @@
|
||||
<div class="relative pl-14 pb-fluid-sm">
|
||||
@if (isFirstRoleAtCompany(i)) {
|
||||
<img src="{{entry.logo}}" alt="" aria-hidden="true"
|
||||
class="absolute left-0 top-0 w-10 h-10 object-contain opacity-90 rounded-[10%] bg-logo-bg"
|
||||
[class.invert]="entry.invertLogo" />
|
||||
class="absolute left-0 top-0 w-10 h-10 object-contain opacity-90 rounded-[10%] bg-logo-bg" />
|
||||
<div class="font-semibold opacity-90 text-[clamp(0.9rem,2.2vw,1.05rem)] leading-10" data-testid="company">
|
||||
{{ (entry.key + '.COMPANY') | translate }}
|
||||
</div>
|
||||
|
||||
@@ -5,7 +5,6 @@ import { MatIconRegistry } from '@angular/material/icon';
|
||||
import { provideRouter } from '@angular/router';
|
||||
import { provideTranslateService } from '@ngx-translate/core';
|
||||
import { AboutComponent } from './about.component';
|
||||
import { AssetsConstants } from '../../constants/AssetsConstants';
|
||||
|
||||
/**
|
||||
* No translations are loaded, so the translate pipe echoes the key back. That is
|
||||
@@ -111,16 +110,6 @@ describe('AboutComponent', () => {
|
||||
expect(textOf('[data-testid="role"]')).not.toContain('ABOUT.XP.COMPANY0.ROLE');
|
||||
});
|
||||
|
||||
it('inverts the opaque white logos so they read as dark tiles', () => {
|
||||
const inverted = fixture.debugElement
|
||||
.queryAll(By.css('img.invert'))
|
||||
.map(img => new URL(img.nativeElement.src, 'http://localhost').pathname);
|
||||
const expected = [AssetsConstants.COLORDIGITAL_LOGO, AssetsConstants.TERAPORT_LOGO]
|
||||
.map(src => new URL(src, 'http://localhost/').pathname);
|
||||
|
||||
expect(new Set(inverted)).toEqual(new Set(expected));
|
||||
});
|
||||
|
||||
it('reveals the earlier positions when the toggle button is clicked', () => {
|
||||
click('toggle-experience');
|
||||
|
||||
|
||||
@@ -17,8 +17,6 @@ interface ExperienceEntry {
|
||||
company: string;
|
||||
logo: string;
|
||||
highlightCount: number;
|
||||
/** The source file is opaque white; inverting gives the same dark tile as the other logos. */
|
||||
invertLogo?: boolean;
|
||||
}
|
||||
|
||||
interface SkillGroup {
|
||||
@@ -52,29 +50,25 @@ export class AboutComponent {
|
||||
key: 'ABOUT.XP.COMPANY9',
|
||||
company: 'colordigital',
|
||||
logo: AssetsConstants.COLORDIGITAL_LOGO,
|
||||
highlightCount: 3,
|
||||
invertLogo: true
|
||||
highlightCount: 3
|
||||
},
|
||||
{
|
||||
key: 'ABOUT.XP.COMPANY8',
|
||||
company: 'teraport',
|
||||
logo: AssetsConstants.TERAPORT_LOGO,
|
||||
highlightCount: 3,
|
||||
invertLogo: true
|
||||
highlightCount: 3
|
||||
},
|
||||
{
|
||||
key: 'ABOUT.XP.COMPANY7',
|
||||
company: 'colordigital-earlier',
|
||||
logo: AssetsConstants.COLORDIGITAL_LOGO,
|
||||
highlightCount: 3,
|
||||
invertLogo: true
|
||||
highlightCount: 3
|
||||
},
|
||||
{
|
||||
key: 'ABOUT.XP.COMPANY6',
|
||||
company: 'colordigital-earlier',
|
||||
logo: AssetsConstants.COLORDIGITAL_LOGO,
|
||||
highlightCount: 3,
|
||||
invertLogo: true
|
||||
highlightCount: 3
|
||||
},
|
||||
{
|
||||
key: 'ABOUT.XP.COMPANY5',
|
||||
|
||||
Reference in new issue
Block a user